New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsnip::set_model_arg should be "sample_size" not "sample_prop" #52

Open

p-schaefer opened this issue Nov 17, 2021 · 0 comments

p-schaefer commented Nov 17, 2021

Here:

treesnip/R/lightgbm.R

Line 169 in 60aade5

parsnip = "sample_prop",

and this:

treesnip/R/lightgbm.R

Line 171 in 60aade5

func = list(pkg = "dials", fun = "sample_size"),

should be:
func = list(pkg = "dials", fun = "sample_prop"),

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment