feat: 选中工具栏展示位置在最后一行的下方 #501
Conversation
|
|
Warning Rate limit exceeded@liuchuzhang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 59 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe changes modify the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/core/src/menus/helpers/position.ts (1)
94-97: Consider adding documentation for the positioning logicThe implementation elegantly handles multi-line selections by using the last rectangle for positioning. Consider adding a comment explaining this design decision, as it's a key behavior that future maintainers should understand.
+ // For multi-line selections, position the toolbar below the last line + // to avoid overlapping with the selected text const rects = range.getClientRects() const lastRect = rects[rects.length - 1]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/core/src/menus/helpers/position.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: test-e2e
- GitHub Check: test
🔇 Additional comments (1)
packages/core/src/menus/helpers/position.ts (1)
66-66: LGTM: Safely removed unused height destructuringThe removal of the height property from the destructuring assignment is appropriate as it's no longer needed in the calculations.
| const rects = range.getClientRects() | ||
| const lastRect = rects[rects.length - 1] | ||
|
|
||
| let t = lastRect.top - containerTop + lastRect.height |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add safety check for empty selection rectangles
The change correctly positions the toolbar below the last line of selection. However, we should add a safety check for cases where the selection might not have any rectangles.
Consider adding a safety check:
const rects = range.getClientRects()
+ if (rects.length === 0) return defaultStyle
const lastRect = rects[rects.length - 1]
let t = lastRect.top - containerTop + lastRect.heightCommittable suggestion skipped: line range outside the PR's diff.
liuchuzhang
force-pushed
the
fix/toolbar
branch
from
c27d97a to
c657787
Compare
liuchuzhang
force-pushed
the
fix/toolbar
branch
from
c657787 to
b1bd781
Compare
Changes Overview
Implementation Approach
Testing Done
Verification Steps
Additional Notes
Checklist
Related Issues
Close #500
Summary by CodeRabbit