Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings dialog, TTS voices page: display names of TTS engines #228

Closed
marisademeglio opened this issue Jun 4, 2024 · 5 comments
Closed
Assignees
Milestone

Comments

@marisademeglio
Copy link
Member

marisademeglio commented Jun 4, 2024

@bertfrees commented

In the voices dialog, you capitalize the engine name. Engines also have a "display name". I will make that available in the web API.

Is there a (pipeline) engine issue for this that we can monitor?

@marisademeglio marisademeglio changed the title TTS dialog engine names TTS voices dialog: display names of TTS engines Jun 4, 2024
@marisademeglio marisademeglio changed the title TTS voices dialog: display names of TTS engines Settings dialog, TTS voices page: display names of TTS engines Jun 4, 2024
@bertfrees
Copy link
Member

See daisy/pipeline-modules#94

@bertfrees
Copy link
Member

Note that daisy/pipeline-modules#94 is done, but I'm not sure if the changes are included in the engine snapshot that you are currently using in the GUI. I think they are.

@marisademeglio
Copy link
Member Author

marisademeglio commented Jun 28, 2024

Yes it's already there but the names need to be shorter. This is what the endpoint returns for me:

<tts-engines href="http://localhost:49152/ws/tts-engines">
    <tts-engine name="osx-speech" nicename="macOS" status="available" voices="http://localhost:49152/ws/voices?engine=osx-speech"/>
    <tts-engine message="Property not set: org.daisy.pipeline.tts.google.apikey" name="google" nicename="Google Cloud" status="disabled"/>
    <tts-engine features="speech-rate" name="azure" nicename="Microsoft Azure" status="available" voices="http://localhost:49152/ws/voices?engine=azure"/>
</tts-engines>

marisademeglio added a commit that referenced this issue Jun 28, 2024
Use the engine's name as reported by `/ws/tts-engines` in the engines and voices screens of the settings dialog.

#228
@bertfrees
Copy link
Member

Yes, names have been made shorter also but that part has not end up in the snapshot yet.

@marisademeglio
Copy link
Member Author

Ok, well the UI change has been incorporated, it'll use whatever the engine provides. I think we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants