Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement press on log message can take to filter or exclude popup #30

Open
michaelsam94 opened this issue Jan 24, 2019 · 2 comments
Open

Enhancement press on log message can take to filter or exclude popup #30

michaelsam94 opened this issue Jan 24, 2019 · 2 comments
Labels
enhancement

Comments

@michaelsam94
Copy link
Contributor

when pressing on logcat message the user can filter or exclude with pressed log message
@michaelsam94
Copy link
Contributor Author

can put two items in popup menu when long press on message and when click on those items I put extra to intent with selected message

michaelsam94 added a commit to michaelsam94/LogcatReader that referenced this issue Feb 2, 2019
@michaelsam94
Enhancement press on log message can take to filter or exclude popup d…
03af8ad 
…arshanparajuli#30
@darshanparajuli
Copy link
Owner

Hey Michael,

Thanks for the PR. Here's my initial feedback:

  • The FilterExclusion dialog does not need a title
    • Filter or Exclude title seems redundant for a dialog with two items: Filter, Exclude
  • The log type on the Filter or Exclusion dialog (next screen) is not set after tapping on Filter or Exclude on FilterExclusion dialog
  • Log level filter/exclusion seems to be broken
  • Some code cleanup is needed

darshanparajuli pushed a commit that referenced this issue Feb 5, 2019
@michaelsam94 @darshanparajuli
Enhancement press on log message can take to filter or exclude popup #30
42d07ec 
 (#31)

* Enhancement press on log message can take to filter or exclude popup #30

* changes requested in pull request #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darshanparajuli @michaelsam94