From 5fdb05c4c23e2b2ff638e9373cd8fc3ababccc00 Mon Sep 17 00:00:00 2001 From: fanquake Date: Wed, 26 Jul 2023 09:44:01 +0100 Subject: [PATCH] Merge bitcoin/bitcoin#28150: test: Avoid intermittent issues due to async events in validationinterface_tests faca9a3d5a6887517d02b994a43d0e1101b718bc test: Avoid intermittent issues due to async events in validationinterface_tests (MarcoFalke) Pull request description: Currently the tests have many issues: * They setup the genesis block, even though it is not needed * They queue an async `UpdatedBlockTip` even, which causes intermittent issues: https://github.com/bitcoin/bitcoin/issues/28146#issuecomment-1650064645 Fix all issues by trimming down the setup to just `ChainTestingSetup`. ACKs for top commit: Crypt-iQ: tACK faca9a3d5a6887517d02b994a43d0e1101b718bc Tree-SHA512: 4449040330f89bbaf5ce5b2052417c160b451c373987fdf1069596c07834ed81f0aea1506d53c7d2cd21062b27332d30679285dae194b272fd0cb9ce5ded32cf --- src/test/validationinterface_tests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/validationinterface_tests.cpp b/src/test/validationinterface_tests.cpp index d2fc20e625afaf..1e935a0ba1b056 100644 --- a/src/test/validationinterface_tests.cpp +++ b/src/test/validationinterface_tests.cpp @@ -10,7 +10,7 @@ #include #include -BOOST_FIXTURE_TEST_SUITE(validationinterface_tests, TestingSetup) +BOOST_FIXTURE_TEST_SUITE(validationinterface_tests, ChainTestingSetup) struct TestSubscriberNoop final : public CValidationInterface { void BlockChecked(const CBlock&, const BlockValidationState&) override {}