feat(qt): Governance Tab should respect selected units and settings #6403
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
force-pushed
the
qt_gov_units
branch
from
f074cae to
90923ae
Compare
knst
reviewed
Nov 19, 2024
| case Column::PAYMENT_AMOUNT: | ||
| return proposal->paymentAmount(); | ||
| case Column::PAYMENT_AMOUNT: { | ||
| return BitcoinUnits::floorWithUnit(m_display_unit, proposal->paymentAmount() * COIN, false, |
There was a problem hiding this comment.
hm, I just noticed that proposal->paymentAmount() returns float here.
str_amounts is assigned as string ValueFromAmount(payment.nAmount)) which doesn't lose precision, but conversion back through float and multiplying to COIN can potentionallly add a strange 0.00000002 at the end, I think.
Is it possible to avoid conversion to float here?
if (UniValue amountValue = find_value(prop_data, "payment_amount"); amountValue.isNum()) {
m_paymentAmount = amountValue.get_real(); // <----- here
}
There was a problem hiding this comment.
Good catch! We should be using double here. Will fix in a follow-up PR.
EDIT: #6404
knst
approved these changes
Nov 19, 2024
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Nov 21, 2024
…vernance Tab c48efda fix(qt): avoid potential precision loss in amounts on Governance Tab (UdjinM6) Pull request description: ## Issue being fixed or feature implemented #6403 (comment) ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: knst: utACK c48efda PastaPastaPasta: utACK c48efda Tree-SHA512: 705bc154e10150e32e3ff04d4a90de14e29ffd195cc9f94a753dd1b4588f2730d6526cd66d851005b956e0d074d39250d142baa946bea8df95dbc92718931762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Governance Tab ignores selected units and settings atm. Let's fix this.
Display settings:
develop:
this PR:
What was done?
How Has This Been Tested?
Breaking Changes
Checklist: