Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name of the generated HTML page is 'Actual theme for JSON Resume' #16

Closed
wjam opened this issue Jan 16, 2022 · 2 comments · Fixed by #23
Closed

Name of the generated HTML page is 'Actual theme for JSON Resume' #16

wjam opened this issue Jan 16, 2022 · 2 comments · Fixed by #23
Labels
good first issue Good for newcomers

Comments

@wjam
Copy link

wjam commented Jan 16, 2022

I'm poking around with jsonresume and associated themes and noticed that the title of the HTML page is 'Actual theme for JSON Resume' rather than something meaningful like resume.basics.name.
@davcd
Copy link
Owner

davcd commented Feb 14, 2022

Hello @wjam many thanks for your comments, I'm agree with this and I going to change it in the next release of the theme.

@davcd davcd added the good first issue Good for newcomers label Feb 14, 2022
@maartenpaauw maartenpaauw mentioned this issue May 3, 2022
Merged
@maartenpaauw
Copy link
Contributor

I've create a pull request which will use the name and the label as title. For example: "Richard Hendrik - Software Developer".

@davcd davcd closed this as completed in #23 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feature] Display name and label in title maartenpaauw/jsonresume-theme-actual
3 participants
@wjam @maartenpaauw @davcd