Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3533] dbt docs generate doesn't hide package's documentation #487

Closed
hvignolo87 opened this issue Jan 8, 2024 · 3 comments
Closed
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@hvignolo87
Copy link

Describe the bug

I'm using the following stack:

  • poetry 1.6.1
  • dbt-core 1.5.6
  • dbt-redshift 1.5.7
  • dbt_utils 1.1.1

This is my dbt_project.yml:

models:
  bind: false
  my_project:
    +full_refresh: false
    +on_schema_change: "append_new_columns"
    ...

  dbt_utils:
    +docs:
      show: false

This is my packages.yml:

packages:
  - package: dbt-labs/dbt_utils
    version: 1.1.1

When I run any of these commands:

poetry run dbt docs generate --project-dir my_project --profiles-dir my_project
poetry run dbt docs generate --select my_project --exclude dbt_utils --project-dir my_project --profiles-dir my_project
cd my_project && poetry run dbt docs generate
cd my_project && poetry run dbt docs generate --select my_project --exclude dbt_utils

Or any other combination, when I render the documentation, the package's docs are shown under Projects.

Steps To Reproduce

Create a dummy project and try:

  • Run dbt init
  • Complete your credentials in profiles.yml
  • Add dbt_utils 1.1.1 to packages.yml
packages:
  - package: dbt-labs/dbt_utils
    version: 1.1.1
  • Run dbt deps
  • Exclude the docs in dbt_project.yml by adding:
models:
  ...

  dbt_utils:
    +docs:
      show: false
  • Run any of the above commands, like dbt docs generate
  • Run dbt docs serve --browser --port 8888

Expected behavior

The package's documentation is not shown in the rendered HTML.

Screenshots and log output

N/A

Additional context

N/A

@hvignolo87 hvignolo87 added bug Something isn't working triage labels Jan 8, 2024
@github-actions github-actions bot changed the title dbt docs generate doesn't hide package's documentation [CT-3533] dbt docs generate doesn't hide package's documentation Jan 8, 2024
@dbeatty10
Copy link
Contributor

Thanks for reaching out @hvignolo87 !

Following your example, it looks like the documentation website includes the macros directory from dbt_utils:

image

Typically, disabling a particular resource type (like macros) is accomplished like this in dbt_project.yml:

macros:
  dbt_utils:
    +docs:
      show: false

But the macro resource type is the one thing that is not able to be configured in dbt_project.yml right now.

We already have an issue for that in dbt-labs/dbt-core#8061, so I'm going to close this one as a duplicate.

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
@dbeatty10 dbeatty10 added duplicate This issue or pull request already exists and removed triage labels Jan 9, 2024
@github-actions github-actions bot added the triage label Jan 9, 2024
@hvignolo87
Copy link
Author

Hi @dbeatty10! Hope you're doing well.

Thanks for your reply! I didn't find that issue before 😅

@dbeatty10
Copy link
Contributor

Good to see you again @hvignolo87. No worries... it took me a little while to find that one even though I knew it existed (somewhere).

@dbeatty10 dbeatty10 removed the triage label Jan 9, 2024
@github-actions github-actions bot added the triage label Jan 9, 2024
@dbeatty10 dbeatty10 removed the triage label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants