Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Snowflake China host OAuth connection snowflakecomputing.cn #1024

Open
3 tasks done
AndrewCanva opened this issue May 7, 2024 · 5 comments
Open
3 tasks done
Labels

Comments

@AndrewCanva
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Snowflake has initiated the private preview of their product in China, with plans to transition into a public preview in June 2024. Presently, connections to Snowflake China are not possible through the standard snowflakecomputing.com host; instead, the regional host snowflakecomputing.cn must be used.

Describe alternatives you've considered

N/A

Who will this benefit?

dbt and snowflake users in China

Are you interested in contributing this feature?

yes

Anything else?

N/A

@jtcohen6
Copy link
Contributor

Hey @AndrewCanva, thanks for opening!

Do you happen to know more details (or could link us to documentation) about Snowflake China?

dbt-snowflake connects to Snowflake using snowflake-connector-python, by passing in the account identifier. However snowflake-python-connector wants to receive region/organization/account identifiers for Snowflake China, that's how we'll want to provide it as well.

@AndrewCanva
Copy link
Author

Hey @AndrewCanva, thanks for opening!

Do you happen to know more details (or could link us to documentation) about Snowflake China?

dbt-snowflake connects to Snowflake using snowflake-connector-python, by passing in the account identifier. However snowflake-python-connector wants to receive region/organization/account identifiers for Snowflake China, that's how we'll want to provide it as well.

@jtcohen6 the error was gone after I added host parameter in the connection profile because I used snowflake/externalbrowser authenticator, but I guess it would cause errors if oAuth authenticator method is configured re

_TOKEN_REQUEST_URL = "https://{}.snowflakecomputing.com/oauth/token-request"

@jtcohen6
Copy link
Contributor

@AndrewCanva Makes sense. I'm going to keep this one on the backlog for now, and we can pick it up when someone needs it. Good to have it searchable in the meantime.

@AndrewCanva AndrewCanva changed the title [Feature] Support Snowflake China host connection snowflakecomputing.cn [Feature] Support Snowflake China host OAuth connection snowflakecomputing.cn May 16, 2024
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 12, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
@amychen1776 amychen1776 removed the Stale label Nov 25, 2024
@amychen1776 amychen1776 reopened this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants