Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] missing @dataclass decorator from both SnowflakeRelationType `SnowflakeIncludePolicy #1042

Open
2 tasks done
dataders opened this issue May 15, 2024 · 2 comments
Open
2 tasks done

Comments

@dataders
Copy link
Contributor

Is this a new bug in dbt-snowflake?

  • I believe this is a new bug in dbt-snowflake
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

class SnowflakeRelationType(StrEnum):
Table = "table"
View = "view"
CTE = "cte"
External = "external"
DynamicTable = "dynamic_table"
class SnowflakeIncludePolicy(Policy):
database: bool = True
schema: bool = True
identifier: bool = True

Expected Behavior

they should be dataclasses!

Steps To Reproduce

n/a

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-snowflake:

Additional Context

No response

@dataders dataders added type:bug Something isn't working triage:product labels May 15, 2024
@jtcohen6 jtcohen6 added type:task and removed type:bug Something isn't working triage:product labels May 16, 2024
@mikealfare
Copy link
Contributor

@dataders I know you found an issue that this caused but I can't remember what it was. If you remember, could you please add it?

@dataders
Copy link
Contributor Author

The issue I came across was that I copied Snowflakes policies.py to use as a starting point to implement IncludePolicy for another adapter that actually required database to no be included.

Sometimes I see errors related to this, but it's never the culprit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants