Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide universal embedabble attributes for element #211

Open
kdziedzic68 opened this issue Nov 28, 2024 · 0 comments
Open

feat: provide universal embedabble attributes for element #211

kdziedzic68 opened this issue Nov 28, 2024 · 0 comments
Labels
feature New feature or request

Comments

@kdziedzic68
Copy link
Collaborator

kdziedzic68 commented Nov 28, 2024

Feature description

  1. Base Element class should have optional embeddable_text and embeddable_image properties defining the content for the two currently supported embedding types
  2. To create the embeddable_text property should we should simply rename the current key property to embeddable_text
  3. The implementation embeddable_image in the base Element class should simply always return None. The ImageElement class should override this implementation to return the bytes of the image instead.
  4. Proper adjustments should be made in insert_element method of DocumentSearch

Motivation

Current implementation assumes that emedded images are instances of ImageElement. we should make it more flexible to potentially support different classes

Additional context

No response

@kdziedzic68 kdziedzic68 added the feature New feature or request label Nov 28, 2024
@mhordynski mhordynski assigned mhordynski and unassigned mhordynski Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants