Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keyboard accessible #36

Open
ChrisBAshton opened this issue Jun 24, 2018 · 0 comments
Open

Make keyboard accessible #36

ChrisBAshton opened this issue Jun 24, 2018 · 0 comments

Comments

@ChrisBAshton
Copy link

ChrisBAshton commented Jun 24, 2018

Hello! 👋Just seen your plugin on http://www.theboardroomclimbing.com/ and discovered it wasn't very keyboard accessible. It's the last element in the DOM but it's visually the first thing in the page, so I'd expect the first tab of the keyboard to go to the Whatever button:

screen shot 2018-06-24 at 14 49 19

Currently have to tab through all of the links on the page before I'm able to dismiss the cookie notice.

Not too sure about the plugin internals, but would suggest attaching the cookie notice to the top of the DOM rather than the bottom, and/or applying tabindex="1" on the buttons to bring them up in the tab order.

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant