Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs don't 'complete with error' when start_job fails #81

Open
g-kimbell opened this issue May 24, 2024 · 2 comments
Open

jobs don't 'complete with error' when start_job fails #81

g-kimbell opened this issue May 24, 2024 · 2 comments
Labels

Comments

@g-kimbell
Copy link

When starting a job, if the biologic says it is in state "RUN" the job never starts, and it never switches to 'ce' (completed with error), it stays in a frozen running state and has to be manually cancelled.

The same happens if an error is thrown by drivers.biologic.start_job (e.g. there is a problem with the payload or the firmware isn't loaded), the job stays frozen and running.

@PeterKraus
Copy link
Contributor

I think in general, we need to be more thorough about catching exceptions, logging them, and trying to recover.

@PeterKraus PeterKraus added this to the 1.0 milestone Jul 17, 2024
@PeterKraus
Copy link
Contributor

PeterKraus commented Nov 19, 2024

This will have to be tested in the eventual tomato-biologic. Keeping the issue open until it can be transferred to that repo.

@PeterKraus PeterKraus removed this from the 1.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants