Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow separate xvalues for self and target objects in scale_to() #290

Open
yucongalicechen opened this issue Dec 29, 2024 · 0 comments
Milestone

Comments

@yucongalicechen
Copy link
Contributor

          This will be the default behavior so should go first in the docs.    Then we can say something like "if this doesnlt give desirable results you can user....." and describe the other workflow.

To give even more flexibility to the user we may want to allow them to specify a separate xtype and xvalue for the target and the scaled DO. The hierarchy woiuld be:

  1. no xtype/xvalue
  2. if that doesn't give desirable results, specify xtype and xvalue for target. scale to the same (nearest) point in the scaled pattern
  3. if that doesn't give desirable results, specify xtype, and a different xvalue for target. and scaled DO, respectively. Scale the yvale of xvalue_scaled to yvalue of xvalue_target.

This last functionality is a new one and we should put it on a new issue (and a new PR if we want to implement it)

Originally posted by @sbillinge in #289 (comment)

@yucongalicechen yucongalicechen added this to the 3.7.0 release milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant