Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do we need an xunit? #314

Open
sbillinge opened this issue Jan 1, 2025 · 0 comments
Open

fix: do we need an xunit? #314

sbillinge opened this issue Jan 1, 2025 · 0 comments
Milestone

Comments

@sbillinge
Copy link
Contributor

Problem

xtype = "q" could be in inverse angstroms or inverse nm. In principle tth could be in angles or radians, though in practice I have never seen it in radians

Proposed solution

have an optional variable xunit. Maybe have default units and always convert to these internally, in whiich case, xunit is only used in the constructor.

@sbillinge sbillinge added this to the 3.7.0 release milestone Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant