Change DPI to 96 #1781
Change DPI to 96 #1781
Conversation
|
|
|
Thanks for creating this PR but I am not sure if this would be the best solution. Maybe we could add an extra |
|
Yeah, okay, that sounds good. |
|
Will you be going to make these changes or do you want me to do this? |
|
I don't know anything about how that dpi test would work. I think it would be better if you did it. |
|
In the unit test you would need to check if the |
| /// </summary> | ||
| /// <param name="self">The image.</param> | ||
| /// <typeparam name="TQuantumType">The quantum type.</typeparam> | ||
| /// <returns>A <see cref="WriteableBitmap"/>.</returns> | ||
| public static unsafe WriteableBitmap ToWriteableBitmap<TQuantumType>(this IMagickImage<TQuantumType> self) | ||
| where TQuantumType : struct, IConvertible | ||
| { |
There was a problem hiding this comment.
I would create a private method that has the current implementation and specify either new Vector(96, 96) or new Vector(self.Density.X, self.Density.Y) as an argument to that method.
There was a problem hiding this comment.
I updated it with ToWriteableBitmapInternal and sending argument between the two.
Fixes #1780