Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning blockquotes do not render sub-elements correctly #1588

Open
shawaj opened this issue Jun 6, 2021 · 2 comments · May be fixed by #2487
Open

warning blockquotes do not render sub-elements correctly #1588

shawaj opened this issue Jun 6, 2021 · 2 comments · May be fixed by #2487
Milestone

Comments

@shawaj
Copy link

shawaj commented Jun 6, 2021

Bug Report

Steps to reproduce

Attempt to add a warning tip using the !> tag, running over multiple lines with a nested list, for example:

!> * list item 1
!> * list item 2
!> * list item 3

What is current behaviour

The warning tag does not allow sub elements to be rendered correctly because it uses paragraph tags instead of div tags.

Currently, if you put !> tags over multiple lines, you get the following output:
Screenshot 2021-06-06 at 00 27 09

Or if you add line breaks:
Screenshot 2021-06-06 at 00 38 58

What is the expected behaviour

Ideally, this should work similar to the > blockquote tag where it still allows you to put lists and other elements nested below it:
Screenshot 2021-06-06 at 00 33 57

This can be achieved by rendering it inside <div> tags instead of <p> tags as follows:
Screenshot 2021-06-06 at 01 07 56

Other relevant information

N/A

Please create a reproducible sandbox

N/A

Mention the docsify version in which this bug was not present (if any)

N/A

@trusktr
Copy link
Member

trusktr commented Jun 6, 2021

Good catch, thanks! A fix shouldn't be too hard.

@martinm82
Copy link

Any chance this will be fixed in the near future?

@jhildenbiddle jhildenbiddle added this to the 5.x milestone Jun 16, 2024
@jhildenbiddle jhildenbiddle linked a pull request Aug 8, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants