Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify SqlClientDiagnostic design introduction #3095

Open
cheenamalhotra opened this issue Jan 7, 2025 · 0 comments · Fixed by #3101
Open

Clarify SqlClientDiagnostic design introduction #3095

cheenamalhotra opened this issue Jan 7, 2025 · 0 comments · Fixed by #3101
Assignees
@cheenamalhotra
Milestone
6.0.0

Comments

@cheenamalhotra
Copy link
Member

cheenamalhotra commented Jan 7, 2025 •
edited
Loading

@Wraith2 Can you provide more details why you chose to keep Abstract class "only" in the ref project, while the SqlClientDiagnostic implementations in the main assembly? Why are API surfaces not consistent or was it an oversight?

Secondly, what is the rationale behind Abstract class if the types that emit telemetry don't implement it?

Originally posted by @cheenamalhotra in #2226 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cheenamalhotra cheenamalhotra

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

[Release 6.0] Fix ref assembly definitions for SqlClientDiagnostic APIs (#3097) dotnet/SqlClient
1 participant
@cheenamalhotra