Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency Field - Not Reacting to Parameters Changing #378

Closed
crazyfox55 opened this issue Oct 28, 2024 · 1 comment
Closed

Concurrency Field - Not Reacting to Parameters Changing #378

crazyfox55 opened this issue Oct 28, 2024 · 1 comment

Comments

@crazyfox55
Copy link

crazyfox55 commented Oct 28, 2024

protected override void OnInitialized()
{
if (Property is not null && DbModel is not null)
{
property = Property(DbModel);
if (Model is not null && property is not null)
{
IsDelta = !Property(Model).Equals(property);
}
}
}

This should be using the OnParametersSet, such that when the DbModel changes the property is checked again. Also none of the properties of the Contact have ConcurrencyCheck attributes, so the newest EF core will not automatically fail. I suggest adding the ConcurrencyCheck attribute to at least one property or every property because the UI implies the whole object is checked for concurrency.

@guardrex
Copy link
Collaborator

guardrex commented Oct 28, 2024

Thanks for the report, @crazyfox55.

I'm moving this over to our actual working repo. We ask devs to open issues for us using the Open a documentation issue link/feedback form at the bottom of an article. Issues here are usually just for patch changes, and this one will need the product unit to get involved. Use of the automatic form from the bottom of an article adds metadata to the GitHub issue that cross-links the topic and pings the author automatically for a faster response.

Moved to dotnet/AspNetCore.Docs#33943.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants