Repository navigation
[release/11.0] Use live version of System.Security.Cryptography.Pkcs - #39350
Open
AndriySvyryd with Copilot wants to merge 2 commits into
Open
AndriySvyryd with Copilot wants to merge 2 commits into
AndriySvyryd with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
AndriySvyryd
changed the title
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
No open issues 🎉
What changed in this PR
This PR independently versions System.Security.Cryptography.Pkcs at 11.0.0.
Changes:
- Adds Pkcs dependency metadata and generated properties.
- Exposes the dedicated version property.
- Updates central package pinning.
| File | Description |
|---|---|
eng/Versions.props |
Exposes the dedicated Pkcs version property. |
eng/Version.Details.xml |
Registers the Pkcs dependency. |
eng/Version.Details.props |
Adds the generated package version. |
Directory.Packages.props |
Uses the dedicated central version property. |
Review effort: Lite
AndriySvyryd
marked this pull request as ready for review
October 21, 2026 00:11
Code coverage overviewLanguages: C# C# / code-coverage
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
AndriySvyryd
enabled auto-merge (squash)
October 21, 2026 00:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manage
System.Security.Cryptography.Pkcsindependently instead of tying it to the .NET reference package version. Track its version in dependency metadata and use its dedicated property for the central package pin.11.0.0toVersion.Details.xmland its generated properties; exposeSystemSecurityCryptographyPkcsVersionthroughVersions.props.