You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the current implementation, a common task for latency monitoring will require 4 user-facing interfaces
ILatencyContext which holds the context
ILatencyContextProvider which creates LatencyContext
ILatencyContextTokenIssuer which issues tokens for checkpoints/tags/measures.(BTW, There is an error in the document at README.md#latency-measurement. It is using ILatencyContext.GetCheckpointToken/GetMeasureToken. Both methods are actually defined in ILatencyContextTokenIssuer.)
ILatencyDataExporter which exports latency data.
So the monitored code should always inject 3 interfaces(No.2~4), which is quite wordy. What's more the implementation of LatencyContextTokenIssuer and LatencyContext create their own CheckpointTracker/MeasureTracker/TagCollection which is redundancy.
I would like to propose merge ILatencyContextTokenIssuer/ILatencyDataExporter into ILatencyContext. LatencyContext can hold references to ILatencyContextTokenIssuer/ILatencyDataExporter. Then it becomes the only entrance to issue token and export data.
The text was updated successfully, but these errors were encountered:
For the current implementation, a common task for latency monitoring will require 4 user-facing interfaces
ILatencyContext
which holds the contextILatencyContextProvider
which createsLatencyContext
ILatencyContextTokenIssuer
which issues tokens forcheckpoints/tags/measures
.(BTW, There is an error in the document at README.md#latency-measurement. It is usingILatencyContext.GetCheckpointToken/GetMeasureToken
. Both methods are actually defined inILatencyContextTokenIssuer
.)ILatencyDataExporter
which exports latency data.So the monitored code should always inject 3 interfaces(No.2~4), which is quite wordy. What's more the implementation of
LatencyContextTokenIssuer
andLatencyContext
create their ownCheckpointTracker/MeasureTracker/TagCollection
which is redundancy.I would like to propose merge
ILatencyContextTokenIssuer/ILatencyDataExporter
intoILatencyContext
.LatencyContext
can hold references toILatencyContextTokenIssuer/ILatencyDataExporter
. Then it becomes the only entrance to issue token and export data.The text was updated successfully, but these errors were encountered: