Cache Embedded Resources during compilation task #10928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sbuild into dev/jenny/issue10644
|
@JanKrivanek please help with this test failure |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…net build' is incomplete
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/Tasks/Microsoft.Common.CurrentVersion.targets: Language not supported
Comments suppressed due to low confidence (1)
src/Build.UnitTests/ProjectCache/ProjectCacheTests.cs:1664
- The comment should start with a capital letter: 'The netfx bootstrap layout created with 'dotnet build' is incomplete'.
/// <summary>
JanKrivanek
approved these changes
Jan 8, 2025
| @@ -1656,5 +1659,73 @@ private void SetEnvironmentForErrorLocations(ErrorLocations errorLocations, Erro | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| [DotNetOnlyFact("The netfx bootstrap layout created with 'dotnet build' is incomplete")] | |||
There was a problem hiding this comment.
Is this still true?
What happens with the test when run for core?
SimaTian
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10644 and #5334
Context
Fast up-to-date check with SDK project doesn't see new embedded resources!
Changes Made
Add @(_CoreCompileResourceInputs) to CoreCompileCache item, to include them in the cache file which gets
included in the CoreCompile target.
Testing
EmbeddedResourcesFileCompileCache()
Notes
See dotnet/project-system#5794 for more details.