Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat request] Square-crop Notification Albumart #79

Open
lovegaoshi opened this issue Jun 27, 2023 · 2 comments · May be fixed by #97
Open

[feat request] Square-crop Notification Albumart #79

lovegaoshi opened this issue Jun 27, 2023 · 2 comments · May be fixed by #97

Comments

@lovegaoshi
Copy link

I wonder if anyone else would find this issue helpful, or if devs are interested in implementing this/pulling my changes?

I unfortunately uses Samsung as my main phone and OneUI's android 13 doesnt have the new mediaSession notification style. What we got is the old school squared album art on the left, and metadata on the right. While I do try to keep all my album arts to be as square as possible, occasionally there are landscape or portrait album arts mixed in. The squared album art does a "contain" instead of "cover" so annoying white spaces will show. My solution is to crop any loading album art to squares: c514071

Although is this a good idea to push a PR or better kept in my own repo?

Samsung's media notification looks like:
https://www.reddit.com/r/oneui/comments/x46hbm/concept_one_ui_5_what_couldve_been_notifications/

@dcvz
Copy link
Contributor

dcvz commented Sep 19, 2023

@lovegaoshi what do your changes look like on other devices using the new media session on other devices?

@lovegaoshi
Copy link
Author

im using a 1280*720 pic https://i.ytimg.com/vi/5IOVkstxkdE/maxresdefault.jpg
cropped pixel ->not cropped pixel -> cropped samsung -> not cropped samsung
Untitled
i guess its better to make it as an option...
and very unfortunately oneUI6 still (partly) has this square notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants