From d5e54a9f22620c81e249f205bdcf490800e8f20d Mon Sep 17 00:00:00 2001 From: Bart Oldeman Date: Thu, 7 Dec 2023 15:02:51 +0000 Subject: [PATCH] Use fail_on_error=False in det_cmake_version(). It handles errors itself already by just looking at the output, no need also do it in run_shell_cmd here. This fixes the test case for det_cmake_version(). --- easybuild/easyblocks/generic/cmakemake.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/easybuild/easyblocks/generic/cmakemake.py b/easybuild/easyblocks/generic/cmakemake.py index 030783df05..6838a68168 100644 --- a/easybuild/easyblocks/generic/cmakemake.py +++ b/easybuild/easyblocks/generic/cmakemake.py @@ -63,7 +63,7 @@ def det_cmake_version(): regex = re.compile(r"^[cC][mM]ake version (?P[0-9]\.[0-9a-zA-Z.-]+)$", re.M) cmd = "cmake --version" - cmd_res = run_shell_cmd(cmd, hidden=True) + cmd_res = run_shell_cmd(cmd, hidden=True, fail_on_error=False) out = cmd_res.output res = regex.search(out) if res: