Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does CanMatrix.signalDefines have to be 'dynamic'? #125

Open
altendky opened this issue Dec 29, 2017 · 1 comment
Open

Does CanMatrix.signalDefines have to be 'dynamic'? #125

altendky opened this issue Dec 29, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@altendky
Copy link
Collaborator

I just ran into an issue where I generated a CanMatrix in code (as opposed to loading from a .sym file or such) and when I dumped to a .sym the signal defaults ('GenSigStartValue') were not being output. This was because I had not added that to the signalDefines.

The sparse nature of the CanMatrix.attributes attribute itself already provides both not-present and None options for each define/attribute. What does the extra not-in-the-defines-list option mean on top of that?

I temporarily addressed my case by copy/pasting this into my code but that doesn't seem great.

db.addSignalDefines("GenSigStartValue", 'FLOAT -3.4E+038 3.4E+038')
db.addSignalDefines("HexadecimalOutput", 'BOOL False True')
db.addSignalDefines("DisplayDecimalPlaces", 'INT 0 65535')
db.addSignalDefines("LongName", 'STR')
@ebroecker ebroecker self-assigned this Apr 6, 2018
@ebroecker ebroecker added this to the 0.7 milestone Apr 6, 2018
@ebroecker ebroecker modified the milestones: 0.7, 0.8 Feb 16, 2019
@ebroecker
Copy link
Owner

GenSigStartValue is now a generic signal attribute:
signal.initial_value

My current plan is to remove "defines" from other formats than dbc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants