Replies: 2 comments 1 reply
-
I'll let @paullatzelsperger comment on the launcher structure as he had a proposal for simplifying that. Regarding JUnit, I do think EdcExtension fits the bill of a launcher because it bootstraps a JUnit runtime. It shouldn't be in a lib module since those types of modules should only contain utility code/functions, not runtime-related code. |
Beta Was this translation helpful? Give feedback.
-
@ndr-brt so they're not the same :)
Launchers are essentially build files, with the option to add custom startup code (the We can move the launchers to the samples directory for all I care so long as we remain aware of the fact that there is a difference between them and the other samples. |
Beta Was this translation helpful? Give feedback.
-
What's the reason to keep two different folders for these modules?
Is
launchers
folder still useful? Aren't launchers samples themselves?e.g.
basic
launcher is the same as the sample01-basic-connector
but with some added dependenciesids-connector
launcher is also a samplejunit
launcher is not really a launcher, it contains theEdcExtension
class that is an util class and maybe it could be moved into a "test-util" libregistration-service-app
launcher is also a sample.So I think we could move all the launchers into the sample folder
Beta Was this translation helpful? Give feedback.
All reactions