Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bazel Typo #2364

Closed
elfenpiff opened this issue Oct 17, 2024 · 0 comments · Fixed by #2363
Closed

Fix Bazel Typo #2364

elfenpiff opened this issue Oct 17, 2024 · 0 comments · Fixed by #2363

Comments

@elfenpiff
Copy link
Contributor

Required information

Currently if you want to depend on Iceoryx as a Bzlmod bazel_dep you have to do something like

bazel_dep(name = "org_eclipse_iceroyx", repo_name = "iceoryx")
git_override(
    module_name = "org_eclipse_iceroyx",
    commit = "00c5349eabfb1bce5db46efefb39fd9471679be1",
    patches = ["//third_party/iceoryx:iceoryx.patch"],
    remote = "https://github.com/eclipse-iceoryx/iceoryx",
)

It would be nice to fix that typo.

I'll send some follow up PRs to contribute patches that make depending on the module via Bzlmod actually work.

lalten added a commit to lalten/iceoryx that referenced this issue Oct 21, 2024
lalten added a commit to lalten/iceoryx that referenced this issue Oct 21, 2024
lalten added a commit to lalten/iceoryx that referenced this issue Oct 22, 2024
lalten added a commit to lalten/iceoryx that referenced this issue Oct 22, 2024
elBoberido added a commit that referenced this issue Oct 29, 2024
iox-#2364 Fix Bzlmod module name typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant