Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile under Visual Studio 2019 with C++20 #266

Closed
Warwolt opened this issue Dec 17, 2020 · 3 comments
Closed

Does not compile under Visual Studio 2019 with C++20 #266

Warwolt opened this issue Dec 17, 2020 · 3 comments

Comments

@Warwolt
Copy link

Warwolt commented Dec 17, 2020

Hi!

When compiling this project under MSVC 2019 with the standard set to C++20, the Seq.h header fails with error:

Seq.h(37,45): error C2653: 'result_of': is not a class or namespace name 

result_of was depricated in C++17 and has been removed in C++20, and according to notes on cppreference the preferred alternative is to use invoke_result.

@Warwolt
Copy link
Author

Warwolt commented Dec 17, 2020

Just saw that this could potentially be addressed by #261 if it becomes accepted.

@objectx
Copy link
Contributor

objectx commented Apr 2, 2021

To correctly reflect the language level to __cplusplus for MSVC、We must supply the /Zc:__cplusplus option. Otherwise __cplusplus == 199711L 😞

@Warwolt
Copy link
Author

Warwolt commented Feb 6, 2022

I could build this using MSVC with C++20 now, closing this issue.

@Warwolt Warwolt closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants