Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook goes into send loop when readline returns "" #8

Open
Trolldemorted opened this issue Apr 27, 2021 · 11 comments
Open

notebook goes into send loop when readline returns "" #8

Trolldemorted opened this issue Apr 27, 2021 · 11 comments

Comments

@Trolldemorted
Copy link
Member

No description provided.

@gehaxelt
Copy link
Contributor

How can I reproduce the issue?

@Trolldemorted
Copy link
Member Author

That is a very good question /shrug

@gehaxelt
Copy link
Contributor

In that case we can probably close this issue, can't we?

@Trolldemorted
Copy link
Member Author

If you consider that behaviour intentional, then yes, otherwise it is solved by one if clause after the readline

@ldruschk
Copy link
Member

Did this happen to you and you just don't know how to reproduce it, or is this just hypothetical and you don't know whether this can happen in practice?

@Trolldemorted
Copy link
Member Author

grafik

According to my wireshark it happens, my guess it is related to a client socket shutdown, I did not find the time to investigate

@sinitax
Copy link

sinitax commented May 19, 2021

Saw this and took a quick look..

If you close the client connection ch.readline() will always return an empty string -- however, any subsequent call to send results in an exception Broken pipe which ends the process.. so no looping. Where did you get the wireshark capture?

@Trolldemorted
Copy link
Member Author

On my local machine, with the service running in its normal docker container

@sinitax
Copy link

sinitax commented May 19, 2021

but who/what was connecting to the service?

@sinitax
Copy link

sinitax commented May 19, 2021

No checker function caused this looping when I tested it.. just exploit throws an error since it is not yet implemented

@Trolldemorted
Copy link
Member Author

but who/what was connecting to the service?

I think it happened in connections made from the dotnet checker, but not always 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants