Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix extension-server instructions #5013

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

Dean-Coakley
Copy link
Contributor

What this PR does / why we need it:
Updates instructions to match where extension-server config is now loaded from.

Which issue(s) this PR fixes:

Fixes #4811

Release Notes: No

@Dean-Coakley Dean-Coakley requested a review from a team as a code owner January 6, 2025 13:04
@Dean-Coakley
Copy link
Contributor Author

Dean-Coakley commented Jan 6, 2025

@zhaohuabing

  1. Should the fix for this look something like this? I had a look around but I don't see a reference in the code for the expected format in the configmap.
    These changes are a guess based on other docs such as https://github.com/envoyproxy/gateway/blob/main/site/content/en/docs/tasks/observability/gateway-observability.md#metrics

  2. Should the same fix be copied over to versioned docs v1.1 or are the current docs correct?

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.76%. Comparing base (6466ceb) to head (81eec0c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5013    +/-   ##
========================================
  Coverage   66.76%   66.76%            
========================================
  Files         209      209            
  Lines       32255    32358   +103     
========================================
+ Hits        21534    21604    +70     
- Misses       9427     9451    +24     
- Partials     1294     1303     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg requested review from liorokman, zirain and guydc January 6, 2025 17:52
Copy link
Contributor

@liorokman liorokman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkodg arkodg merged commit 8b4cf17 into envoyproxy:main Jan 9, 2025
27 of 28 checks passed
@Dean-Coakley Dean-Coakley deleted the fix-extension-docs branch January 9, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "extension-server" documentation
3 participants