Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on main prevents use from other components (CA-124) #115

Open
NathanJPhillips opened this issue Mar 10, 2021 · 2 comments
Open

Comments

@NathanJPhillips
Copy link

Referencing main from CMakeLists.txt creates a circular dependency that will in many cases cause undefined references during linking when esp-azure is REQUIREd by a component that is in turn REQUIREd by the main project.

Is this a known issue, are there reasons main needs to be referenced, or should I create a PR to remove this?

@github-actions github-actions bot changed the title Dependency on main prevents use from other components Dependency on main prevents use from other components (CA-124) Mar 10, 2021
@liudr
Copy link

liudr commented Mar 11, 2021

I'm curious, what is the reason that main is required in your CMakeLists.txt? I'm learning the CMake build system. This might help me understand what I don't know that I don't know. ;)

@jspngh
Copy link
Contributor

jspngh commented Jul 16, 2021

I ran into the circular dependency issue as well after restructuring some code.
I also don't see a reason for the dependency on main, so it would be good if someone from Espressif can comment whether it can be removed or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants