Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid panics #351

Open
jsign opened this issue May 2, 2023 · 1 comment
Open

Avoid panics #351

jsign opened this issue May 2, 2023 · 1 comment

Comments

@jsign
Copy link
Collaborator

jsign commented May 2, 2023

Do a full-scan of the repository to avoid explicit panics. Even though we usually use them in cases where critical invariants must hold, panicking is very aggressive for at least a graceful shutdown, even in non-recoverable errors.

Also, scan for dependencies (e.g: go-ipa) for the same.

We can do this getting closer to a stable implementation, and definitely before getting close to being fully integrated in geth since it can result in breaking some APIs returning errors instead of panicking.

cc @gballet

@gballet
Copy link
Member

gballet commented Jun 16, 2023

Yeah that's too many

~/s/go-verkle (master)> grep -r panic * | wc -l
29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants