Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with rough edges in network startup #700

Open
acolytec3 opened this issue Dec 29, 2024 · 3 comments · May be fixed by #704
Open

Deal with rough edges in network startup #700

acolytec3 opened this issue Dec 29, 2024 · 3 comments · May be fixed by #704

Comments

@acolytec3
Copy link
Collaborator

The portalnetwork class has a few rough edges related to network start up that we should address. These are currently handled by the cli package but it can lead to not obvious problems trying to start a client inline.

  • The bindAddress parameter needs to have a sensible default. If this is undefined, discv5 crashes the entire application with an uncatchable exception and I'm not sure why
  • We should probably embed the bootnode list in the client as an optional default if people want to quick start a node. This will be especially important in the UltralightProvider class once we merge that updated code in
@cjustinobi
Copy link
Contributor

Hello @acolytec3 can I handle this?

@acolytec3
Copy link
Collaborator Author

Sure, just to note, these changes should be in the portalnetwork package.

  • A sensible default for bindAddress is probably just 0.0.0.0
  • Put the bootnode list in a javascript object and not a JSON file so we can just load it without having to do a JSON import or any file reads.
    If you want to have a look at the docs and add any clarifications you identify related to network startup along the way, that'd be great as well.

@cjustinobi
Copy link
Contributor

Got it!

@cjustinobi cjustinobi linked a pull request Jan 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cjustinobi @acolytec3