-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split out JMAP::Client #46
Comments
|
Agreed on all counts, and I do think turning on/off JSON::Typist on a per-client basis makes sense. Per call does seem silly. As far as I can tell we do no validation of the types inside JMAP::Tester ourselves, so if there's for some reason one place where JSON::Typist is not wanted, it's trivial to strip it. I'm also not against adding it as an option, I just don't see a need (yet). |
Discussion from a Zoom call, 2020-07-02:
|
Since forever, we have talked about having JMAP::Client as the not-just-for-testing JMAP client. I think this is a good idea. I would like to recommend JMAP::Client over Mail::JMAPTalk.
So, what are the blockers?
I think the Futures branch should be completed and merged first, which has a number of downstream implications. (This should likely be its own project.)
Decide whether JMAP::Tester::Abort is appropriate outside of abortable subtests
Decide whether and how to make JMAP::Typist optional. I believe we should, and the main question is whether it's per-Client or per-request, or both.
Brief pow-wow about how Client would play with future planned expansions like: (a) a DataStore-backed cache engine, a la Overture's (b) registered capabilities and automatic accountId selection (c) smarter snap-in method call id generation to allow methods to make backrefs to previous methods without needing to manage their own call ids globally.
The text was updated successfully, but these errors were encountered: