Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move jest rules to eslint-config-feedzai #6

Open
victorfern91 opened this issue Aug 1, 2018 · 1 comment
Open

Move jest rules to eslint-config-feedzai #6

victorfern91 opened this issue Aug 1, 2018 · 1 comment
Assignees
@victorfern91

Comments

@victorfern91
Copy link
Contributor

victorfern91 commented Aug 1, 2018 •
edited
Loading

Right now, the jest rules are included in the eslint-config-feedzai-react and in my opinion, we should remove that rules from eslint-config-feedzai-react and put them into the base package.

I recommend this change because jest rules could be applied to other projects that don't use React.

Don't you agree (@lfac-pt @nancruz)?
@lfac-pt
Copy link
Member

lfac-pt commented Aug 1, 2018

It's not a big deal, but yeah, it makes sense.

@victorfern91 victorfern91 self-assigned this Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victorfern91 victorfern91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lfac-pt @victorfern91