Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local installer fails with spin 0.10.0 #126

Open
ad-ops opened this issue Mar 6, 2023 · 2 comments
Open

Local installer fails with spin 0.10.0 #126

ad-ops opened this issue Mar 6, 2023 · 2 comments

Comments

@ad-ops
Copy link

ad-ops commented Mar 6, 2023

spin v0.10.0 has removed --follow-all which causes Nomad jobs to fail Remove deprecated --follow-all option

Downgrading to spin v0.9.0 solves this.

Installed on macOS

  • spin 0.10.0 (e84ac6c 2023-03-02) --> at the time of issue
  • Nomad v1.5.0
  • Consul v1.15.0

Example log from nomad job:

WARNING: Bindle support is deprecated and will be removed in a future version.
For remote applications, please use registry commands and features instead.
See https://developer.fermyon.com/spin/spin-oci for more details

2023-03-06T21:24:44.375105Z  INFO spin_loader::bindle::assets: Mounting files from 'webserver/0.1.0+qca333d2' to '/private/tmp/.tmpMhCgAf'    
error: Found argument '--follow-all' which wasn't expected, or isn't valid in this context

	Did you mean '--follow'?

	If you tried to supply `--follow-all` as a value rather than a flag, use `-- --follow-all`

USAGE:
    spin trigger http --listen <ADDRESS> --follow <FOLLOW_ID>

For more information try --help
Error: exit status: 2
@vdice
Copy link
Member

vdice commented Mar 7, 2023

@ad-ops thank you for the issue. I see a few options here, in rough order of preference:

  • Update hippo with usage per spin v0.10+, cut a release, bump hippo (and spin for the remote installers) here
  • Implement a mechanism to inform users going the local installer route that spin needs to be pinned to v0.9.0
  • Alternatively, check in w/ the Spin project to see about the feasibility of maintaining a --follow-all alias for --follow in future spin release(s) (would not require hippo release)

@vdice
Copy link
Member

vdice commented Mar 16, 2023

Apologies for the delay here. We do have a new hippo release (https://github.com/deislabs/hippo/releases/tag/v0.20.2) but I'm seeing issues with redeploying apps when using Spin v0.10.1 w/ Hippo v0.20.2 so it appears there may be other areas in Hippo that need updating for compatibility.

For the near term, we'll have to notify users running the installer locally that Spin needs to be pinned to a certain version -- ideally the same as used by the remote installers -- until Hippo is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants