From b832bb58d360583ebd9b6843fb9c8b7e4deb5ba6 Mon Sep 17 00:00:00 2001
From: Lucas Gelfond <lucas_gelfond@brown.edu>
Date: Mon, 23 Dec 2024 16:14:32 -0800
Subject: [PATCH] chrome dependencies gh actions fix x2

---
 .github/workflows/CI.yml | 19 ++++---------------
 package.json             |  2 +-
 2 files changed, 5 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index 8f444c8dd7..7ae42ddd80 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -27,11 +27,6 @@ jobs:
           key: build-cache-st-v1-${{ hashFiles('Dockerfile', 'Makefile', 'build/*') }}
           restore-keys: |
             build-cache-st-v1-
-      - name: Configure sandbox permissions
-        run: |
-          sudo chown root:root chrome_sandbox
-          sudo chmod 4755 chrome_sandbox
-          export CHROME_DEVEL_SANDBOX="$PWD/chrome_sandbox"
       - name: Build ffmpeg-core
         run: make prd EXTRA_ARGS="--cache-from=type=local,src=build-cache-st --cache-to=type=local,dest=build-cache-st,mode=max"
       - name: Upload core
@@ -55,11 +50,6 @@ jobs:
           key: build-cache-mt-v1-${{ hashFiles('Dockerfile', 'Makefile', 'build/*') }}
           restore-keys: |
             build-cache-v1-
-      - name: Configure sandbox permissions
-        run: |
-          sudo chown root:root chrome_sandbox
-          sudo chmod 4755 chrome_sandbox
-          export CHROME_DEVEL_SANDBOX="$PWD/chrome_sandbox"
       - name: Build ffmpet-core-mt
         run: make prd-mt EXTRA_ARGS="--cache-from=type=local,src=build-cache-mt --cache-to=type=local,dest=build-cache-mt,mode=max"
       - name: Upload core-mt
@@ -85,11 +75,6 @@ jobs:
         with:
           name: ffmpeg-core-mt
           path: packages/core-mt/dist
-      - name: Configure sandbox permissions
-        run: |
-          sudo chown root:root chrome_sandbox
-          sudo chmod 4755 chrome_sandbox
-          export CHROME_DEVEL_SANDBOX="$PWD/chrome_sandbox"
       - name: Use Node.js 18
         uses: actions/setup-node@v2
         with:
@@ -104,5 +89,9 @@ jobs:
             node-modules-
       - name: Install dependencies
         run: npm install
+      - name: Install Chrome dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y libgbm-dev libasound2 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 libgbm1
       - name: Run tests
         run: npm test
diff --git a/package.json b/package.json
index 742979d3a0..85e4f09f7e 100644
--- a/package.json
+++ b/package.json
@@ -10,7 +10,7 @@
     "serve": "http-server -c-1 -s -p 3000 .",
     "test": "server-test test:browser:server 3000 test:all",
     "test:all": "npm-run-all test:browser:*:*",
-    "test:browser": "mocha-headless-chrome -a enable-features=SharedArrayBuffer",
+    "test:browser": "mocha-headless-chrome -a enable-features=SharedArrayBuffer -a no-sandbox",
     "test:browser:core:mt": "npm run test:browser -- -f http://localhost:3000/tests/ffmpeg-core-mt.test.html",
     "test:browser:core:st": "npm run test:browser -- -f http://localhost:3000/tests/ffmpeg-core-st.test.html",
     "test:browser:ffmpeg:mt": "npm run test:browser -- -f http://localhost:3000/tests/ffmpeg-mt.test.html",