Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error handling with retries when waiting for receipt #9650

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: error handling with retries when waiting for receipt #9650

wants to merge 2 commits into from

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Jan 8, 2025 •
edited
Loading

Motivation

closes #9636

Solution

@grandizzy grandizzy changed the title fix: err with retries fix: error handling with retries when waiting for receipt Jan 8, 2025
@grandizzy
Copy link
Collaborator Author

@klkvr do you think this makes sense in context of #9636 (comment) ?

@klkvr
Copy link
Member

klkvr commented Jan 9, 2025

I don't think this will address the issue as we're hitting error in different arm #9636 (comment)

we could consider retrying several fatal errors instead of immidiately returning here

foundry/crates/script/src/receipts.rs

Lines 51 to 52 in b4a4733

// treat other errors as fatal
Err(e) => return Err(e.into()),

@grandizzy
Copy link
Collaborator Author

I don't think this will address the issue as we're hitting error in different arm #9636 (comment)

we could consider retrying several fatal errors instead of immidiately returning here

foundry/crates/script/src/receipts.rs

Lines 51 to 52 in b4a4733

// treat other errors as fatal
Err(e) => return Err(e.into()),

yeah, that's what I wanted with https://github.com/foundry-rs/foundry/pull/9650/files#diff-40b142bf1cc0e034c56533fad30c71161b2cc0b4dd4d6a72468e0649e3c7002dR61-R66 what do I miss? thank you!

@klkvr
Copy link
Member

klkvr commented Jan 9, 2025

ah missed that second branch has changed too

lgtm but I'd keep provider.get_transaction_by_hash below so it runs for both cases

@grandizzy grandizzy marked this pull request as ready for review January 9, 2025 11:03
@grandizzy
Copy link
Collaborator Author

ah missed that second branch has changed too

lgtm but I'd keep provider.get_transaction_by_hash below so it runs for both cases

please recheck

@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Jan 9, 2025
DaniPopes
DaniPopes reviewed Jan 10, 2025
View reviewed changes
crates/script/src/receipts.rs
@@ -39,6 +39,7 @@ pub async fn check_tx_status(
return Ok(receipt.into());
}

let mut retries = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the retry utility here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes left review comments

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Status: No status
Milestone
No milestone
3 participants
@grandizzy @klkvr @DaniPopes