Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The prop listIndex is marked as required in CustomThemeNodeContentRenderer #2

Open
svenkle opened this issue Dec 21, 2017 · 2 comments

Comments

@svenkle
Copy link

svenkle commented Dec 21, 2017

When I use the provided examples in combination with this theme I receive the errors in the console (see screenshot). The controls appear to work correctly although I'm not 100% sure there isn't an unforeseen issue.

image

In any case, adding listIndex and lowerSiblingCounts to the declaration appears to have resolved the errors but I'm still raising this as an issue to allow others to find a potential solution and also validation that I haven't unknowingly broken internal functionality.

<SortableTree
    // Removed other elements for clarity
    listIndex: 0,
    lowerSiblingCounts: []
/>
@jcalebj
Copy link

jcalebj commented Jan 30, 2018

@svenkle I think that the syntax might be a little off on the SortableTree part, for anyone else that might be running into this problem.

<SortableTree
  generateNodeProps = {() => ({
    listIndex: 0,
    lowerSiblingCounts: []
  })}
/>

@darewreck54
Copy link

What are these property used for and what do we configure it to. I'm guessing listIndex is the same as treeIndex but do these properties need to be set properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants