Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Consolidate and rename regridding files and functions #267

Open
lizziel opened this issue Oct 11, 2023 · 2 comments
Open
Assignees
Labels
category: Feature Request New feature or request topic: Regridding Issues pertaining to horizontal & vertical regridding

Comments

@lizziel
Copy link
Contributor

lizziel commented Oct 11, 2023

We currently have file_regrid.py and regrid_restart_file.py. The former can regrid restart files which makes this naming confusing. The key difference between the two is file_regrid.py uses regridding weights computed during runtime (online) while regrid_restart_file uses externally produced weights (offline). This is not very intuitive so we should clean it up to be more clear.

Tagging @yantosca and @kilicomu. This update would go on top of recent regridding work in #266.

@lizziel lizziel added the category: Feature Request New feature or request label Oct 11, 2023
@lizziel
Copy link
Contributor Author

lizziel commented Oct 11, 2023

Included in this feature request is to also update the names passed to the regridding functions to be more clear about latlon versus cubed sphare, and type of cubed sphere format. Currently we give 3 options: classic, checkpoint, and diagnostic. We could change this to be latlon, cs_restart, and cs_diagnostic, or break up the argument into grid type and file format: latlon and cubedsphere for grid type, standard and mapl_restart for format. These are just some initial ideas. Open to other ideas too!

@yantosca yantosca self-assigned this Oct 11, 2023
@yantosca yantosca added category: Bug Something isn't working topic: Regridding Issues pertaining to horizontal & vertical regridding and removed no-issue-activity category: Bug Something isn't working labels Dec 11, 2023
@geoschem geoschem deleted a comment from github-actions bot Dec 11, 2023
Copy link

github-actions bot commented Feb 9, 2024

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Regridding Issues pertaining to horizontal & vertical regridding
Projects
None yet
Development

No branches or pull requests

2 participants