'I press' step does not escape single quotes within text

[ThrawnCA]

There is logic in behaving/web/steps/links.py to handle single quotes (which will disrupt XPath) within the specified link text, but this logic is not present in the 'I press "{name"}' step in behaving/web/steps/forms.py, so usage like

I press "Dave's Books"

will fail with "Element not found".

[duttonw]

would you like to contribute a fix for this @ThrawnCA

[ThrawnCA]

@duttonw I don't have that access.

Suggested diff:

diff --git a/src/behaving/web/steps/forms.py b/src/behaving/web/steps/forms.py
index b31074f..aa37466 100644
--- a/src/behaving/web/steps/forms.py
+++ b/src/behaving/web/steps/forms.py
@@ -139,17 +139,22 @@ def i_focus(context, name):
 @when('I press "{name}"')
 @persona_vars
 def i_press(context, name):
+    # Use 'concat' to assemble search string if it contains single quotes.
+    # This will enable even a mixture of single and double quotes.
+    if "'" in name:
+        quoted_name = "concat('" + """', "'", '""".join(name.split("'")) + "')"
+    else:
+        quoted_name = f"'{name}'"
     element = context.browser.find_by_xpath(
         (
-            "//*[@id='%(name)s']|"
-            "//*[@name='%(name)s']|"
-            "//button[contains(string(), '%(name)s')]|"
-            "//input[@type='button' and contains(string(), '%(name)s')]|"
-            "//input[@type='button' and contains(@value, '%(name)s')]|"
-            "//input[@type='submit' and contains(@value, '%(name)s')]|"
-            "//a[contains(string(), '%(name)s')]"
+            f"//*[@id={quoted_name}]|"
+            f"//*[@name={quoted_name}]|"
+            f"//button[contains(string(), {quoted_name})]|"
+            f"//input[@type='button' and contains(string(), {quoted_name})]|"
+            f"//input[@type='button' and contains(@value, {quoted_name})]|"
+            f"//input[@type='submit' and contains(@value, {quoted_name})]|"
+            f"//a[contains(string(), {quoted_name})]"
         )
-        % {"name": name}
     )
     assert (
         element