Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing comment #31

Closed
mprins opened this issue Aug 7, 2023 · 4 comments
Closed

Update existing comment #31

mprins opened this issue Aug 7, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mprins
Copy link

mprins commented Aug 7, 2023

When alt-text is added (and the flagged problem is resolved) the comment placed by the workflow should be removed or hidden (and marked as resolved)

@kendallgassner
Copy link
Collaborator

kendallgassner commented Aug 21, 2023

I am not how easy it would be to track which image the bot comment was referring to 🤔.

We might be able to add a data-attribute inside our comment: <span data-image-name={NAME_OF_IMAGE}></span>. Adding the attribute would allow us to know which comment to remove when the alt text issue is resolved...

Searching through each comment might be costly though.

cc. @khiga8

@khiga8
Copy link
Contributor

khiga8 commented Aug 21, 2023

I love this idea!

Each comment should have a unique ID associated with it so we could try including that as a data attribute in the posted comment like @kendallgassner suggests. For example, @kendallgassner comment URL is https://github.com/github/accessibility-alt-text-bot/issues/31#issuecomment-1686597422. I believe 1686597422 is the unique issue comment ID.

Searching through each comment might be costly though.

Could we filter by bot author and comment body content?

@kendallgassner
Copy link
Collaborator

Could we filter by bot author and comment body content?

O! genius 🧠!!

@kendallgassner
Copy link
Collaborator

Released in v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants