Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto calculation of chunk size is not accounting for mask byte #209

Open
jdbcode opened this issue Jan 3, 2025 · 1 comment
Open

Auto calculation of chunk size is not accounting for mask byte #209

jdbcode opened this issue Jan 3, 2025 · 1 comment
Assignees
Labels
bug Something isn't working P1

Comments

@jdbcode
Copy link
Member

jdbcode commented Jan 3, 2025

Sometimes a request fails because it is too large. The auto chunking function should prevent this from happening. It looks like it is not accounting for the mask byte when calculating bytes per pixel. I believe the fix is to add 1 to dtype_bytes to match how Earth Engine is calculating bytes per pixel. I'm currently testing a change.

Repro: https://gist.github.com/jdbcode/748f7bb5d861f5e096006c7dadbe10b4

@jdbcode jdbcode added bug Something isn't working P1 labels Jan 3, 2025
@jdbcode jdbcode self-assigned this Jan 3, 2025
@jdbcode
Copy link
Member Author

jdbcode commented Jan 6, 2025

#211 Fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant