Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validation to ensure ImpersonatedCredential can only be SA or User Credentials #1602

Open
zhumin8 opened this issue Dec 17, 2024 · 0 comments
Open

add validation to ensure ImpersonatedCredential can only be SA or User Credentials #1602

zhumin8 opened this issue Dec 17, 2024 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Dec 17, 2024

This line in javadoc specifies ImpersonatedCredential can only be SA or User Credentials in this create() method, but it is not enforced.

google-auth-library-java/oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java

Line 120 in a8d466f

* should be either a user account credential or a service account credential.

For context: #1566 (comment)
@zhumin8 zhumin8 added type: docs Improvement to the documentation for an API. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Dec 17, 2024
@zhumin8 zhumin8 mentioned this issue Dec 17, 2024
Open
@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: docs Improvement to the documentation for an API. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhumin8 @lqiu96