Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack and install: should be able to webpack the library failed #1894

Open
flaky-bot bot opened this issue Nov 19, 2024 · 7 comments
Open

pack and install: should be able to webpack the library failed #1894

flaky-bot bot opened this issue Nov 19, 2024 · 7 comments
Assignees
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Nov 19, 2024

Note: #1877 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 0897882
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 19, 2024
Copy link
Author

flaky-bot bot commented Nov 20, 2024

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (0897882), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Nov 20, 2024
@sofisl
Copy link
Contributor

sofisl commented Nov 20, 2024

seems just like a timeout issue, I don't think the library is ready before testing @danielbankhead

@sofisl sofisl added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Nov 20, 2024
@d-goog
Copy link
Collaborator

d-goog commented Nov 20, 2024

@sofisl did you see the logs for both flaky-bot runs?

@sofisl
Copy link
Contributor

sofisl commented Nov 20, 2024

yes

@d-goog
Copy link
Collaborator

d-goog commented Nov 20, 2024

Can you expand on what about the logs between both runs relate to a timeout issue and library readiness?

@sofisl
Copy link
Contributor

sofisl commented Nov 20, 2024

Ah! Yes, here:

found 5 vulnerabilities (2 moderate, 3 high)
  run `npm audit fix` to fix them, or `npm audit` for details
Hash: 27080731c59816c644f5
Version: webpack 4.47.0
Time: 3208ms
Built at: 11/19/2024 9:35:46 AM
                  Asset      Size  Chunks  Chunk Names
../build/src/index.d.ts  11 bytes          
          bundle.min.js  4.81 KiB       0  main
Entrypoint main = bundle.min.js
[0] ./src/index.ts 1.08 KiB {0} [built]

ERROR in ./src/index.ts
Module not found: Error: Can't resolve 'google-auth-library' in '/tmp/google-auth-library-nodejs-pack-GiNh0c/src'
 @ ./src/index.ts 16:30-60

ERROR in bundle.min.js from Terser
Error: Cannot find module '../package.json'

It seems like something is packing the auth library and trying to install it, but it's not actually packed and available, so it seems like maybe there needs to be more time to allow the library to be installed before tests are run. But, I didn't spend too much time on it, so feel free to investigate it further and come up with whatever solution you think is best!

@d-goog d-goog closed this as completed Jan 15, 2025
@flaky-bot flaky-bot bot reopened this Jan 19, 2025
Copy link
Author

flaky-bot bot commented Jan 19, 2025

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 12f2c87
buildURL: Build Status, Sponge
status: failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants