Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init code hell #2

Open
treeder opened this issue Aug 11, 2020 · 0 comments
Open

init code hell #2

treeder opened this issue Aug 11, 2020 · 0 comments

Comments

@treeder
Copy link

treeder commented Aug 11, 2020

This took a long time to figure out, but the init_code for Pair's is hardcoded into router and has to change everytime the factory changes, solidity version changes, or whatever else.

Could have router call this function directly from Factory to get the init_code and use it when generating a pair address: goswap/uniswap-v2-core@2a80c52#diff-baf33e06a441bb84df3d784b143aac5eR50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant