Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings menu/page #15

Closed
mayacakmak opened this issue Jun 24, 2021 · 3 comments
Closed

Settings menu/page #15

mayacakmak opened this issue Jun 24, 2021 · 3 comments

Comments

@mayacakmak
Copy link

We want certain parameters to be exposed to the user as something they can tune themselves or chose amongst options. For this we envision as settings menu accessible through the interface (some type of gear icon on the top right).

Screen Shot 2021-06-24 at 1 56 41 PM

We need to first think about the general way we want to enable this.

  • We probably want the user's setting to be in Firebase so they are remembered. We might want some sort of Javascript global corresponding to each setting variable to be set to the user's preferred value when the connection to the Firebase is first made in the beginning. Setting should be updated whenever the user changes them.
  • Make it programatically easy to add new setting (i.e. should not need to copy paste a bunch of HTML, but instead just call one function with new parameters specifying parameter type and interface type (slider, radio button, text, color picker, etc.)). I have some code from EMAR we could reuse.
  • Have some good defaults for each parameter for new users.
  • I don't think we want settings to be a separate HTML page, but rather have them overlaid or re-render the page without loosing all the JS context. We could just use Bootstrap Modal.

This reminds me we now need to switch to having users log in, rather than be anonymous users. Will add a separate issue for that.

Some things to include in settings off the top of my head (keep adding to this thread as we think of them):

  • Torque feedback sensitivity
  • Continuous action update frequency

@kaviMD let me know what you think about how to implement settings.

@mayacakmak
Copy link
Author

Address Issue #16 first.

@mayacakmak
Copy link
Author

I made a rough version of this by hiding away some things on the interface into a Modal overlay that can be opened from a 'settings' button. Will improve later.

Screen Shot 2021-07-01 at 11 25 11 PM

@nickswalker
Copy link
Member

Closed with f9c1c9d.

Some additional controls added in later commits:
Screenshot from 2022-02-04 11-51-54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants