Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive interface sizing #17

Closed
mayacakmak opened this issue Jun 24, 2021 · 2 comments
Closed

Responsive interface sizing #17

mayacakmak opened this issue Jun 24, 2021 · 2 comments

Comments

@mayacakmak
Copy link

Henry brought up that he would like to have the camera stream be as large as possible and adaptive to the screen size. Not sure if this is straight forward or is there is something absolute (like those overlays) that needs to be adaptable (i.e. turn fized numbers into equations for computing overlay parameters).

@mayacakmak
Copy link
Author

I also addressed this issue while working on the new layout (issue #10). This was quite tricky with the viewbox sizing of the overlays being skewed somehow to fit the size of the video, which appeared to be set to width 300px and hight adjusted based on aspect ratio of whatever height/weight I would set, very strange. I could just not figure out where that 300 came from--well, it turns out a video object is by default 300x150, which was setting the width on the first pass and adjusting the height later.. Now it adjusts the height to use as much of the screen as possible to have larger video rendering, so Henry doesn't need to Zoom onto the interface anymore to see the video image.

@mayacakmak
Copy link
Author

This works quite well (tested on different size screens) and Henry was right that it is quite useful to maximize the camera image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant