Conversation
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
cdobre
force-pushed
the
builder_with_schema
branch
from
March 19, 2026 15:25
0939f3b to
eeeae33
Compare
Collaborator
Author
|
Closing this - we'll go with a different approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to support custom schema received from client in cases where the actual schema is not yet reflected either in table schema or file schema. There is a
DeltaScanBuilderConfigwhich allows customization of schema when reading from files but is used internally.One other aspect is that we need to merge the internal table schema and the custom one received from clients - for AEP datasets for example, the observable schema has no information about the ingestion/internal fields like _ACP_DATE or _ACP_BATCHID and relying only on the observable schema results in being unable to actually read the files.
The PR adds a
schemaproperty to DeltaTableConfig ( where we already have LogLimiter parameters) which can be populated by DeltaTableBuilder by using either a delta schema (Arc) or an arrow schema (Arc).