Is it possible to no load icon packages when initializing fzf-lua?

[casprwang]

Greetings! I'm trying to use fzf-lua without icons, i have tried the following setups

  {
    'ibhagwan/fzf-lua',
    config = function()
      require("fzf-lua").setup {
        defaults   = {
          file_icons    = false,
        },
      }
    end,
  }

and although fzf-lua doesn't show icons, it still loads the icon package during initialization. according to :Lazy profile

        ★  start  fzf-lua 26.73ms
          ‒  fzf-lua/plugin/fzf-lua.lua 0.29ms
          ‒  fzf-lua/plugin/fzf-lua.vim 0.24ms
          ‒  nvim-web-devicons 19.82ms
            ●  nvim-web-devicons/plugin/nvim-web-devicons.vim 0.27ms

as you can see the nvim-web-devicons package takes a huge chunk of fzf-lua init time.

So, is this by design or we can just pass requiring the icon package if icons are turned off? It seems very costly and unnessary when we don't need icons.

[ibhagwan]

116170c

[casprwang]

amazing! eazy 80% perf gain (25ms to 5ms init time)!

[ibhagwan]

amazing! eazy 80% perf gain (25ms to 5ms init time)!

Ty for raising this issue!

[casprwang]

ty for maintaining such great project!

[casprwang]

tested head and it's working as discussed.

[ynhhoJ]

@ibhagwan , now, to make icons appear should be modified config from:

require("fzf-lua").setup {
  "telescope",
}

to

require("fzf-lua").setup {
  "telescope",
  defaults = {
    file_icons = true,
  },
}

It was done on purpose?

[ibhagwan]

@ibhagwan , now, to make icons appear should be modified config from:

require("fzf-lua").setup {
  "telescope",
}

to

require("fzf-lua").setup {
  "telescope",
  defaults = {
    file_icons = true,
  },
}

It was done on purpose?

Yes this was done on purpose in 116170c.

Fzf-lua would trigger lazy loading of the icons package (wrong) which was fixed in the above commit, if you want the icons to be auto detected again (you can still force lazy load with manual file_icons=true as you pointed out) make sure nvim-web-devicons|mini.icons is loaded before fzf-lua by placing it in the dependencies of lazy.nvim

[ynhhoJ]

thx for response!